Work around flaky integration test builds due to gtest #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Currently, we rely on some cmake logic to setup gtest, but this is flaky. To work around this, we run the gtest download script before running the integration test setup script: the latter will copy over gtest alongside the test framework files into the project. This will result in the gtest cmake logic being bypassed. With this in place, the previous workaround of running the android build twice in the presence of a specific failure is no longer necessary. It has been removed.
DellaBitta approved these changes Jan 8, 2021
| | ||
| _run_setup_script(root_dir, project_dir) | ||
| | ||
There was a problem hiding this comment.
This seems like it can be removed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Currently, we rely on some cmake logic to setup gtest, but this is flaky when building for Android. To work around this, this PR changes build_testapps.py to run the gtest download script before running the integration test setup script: the latter will copy over gtest alongside the test framework files into the project. This will result in the problematic gtest cmake logic being bypassed.
With this in place, the previous workaround of running the android build twice in the presence of a specific failure is no longer necessary. It has been removed.