Minor fixes to testing in the packaging workflow #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Build and execution has been separated and was applied to the integration_tests workflow, but not the cpp-packaging workflow.
The new version fixes an issue with environment variables.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Desktop integration testing was separated from the build script, but not applied to the testing in the packaging workflow (or possibly lost during merge conflict resolution). This applies it, consistent with the integration_tests.yml workflow.
Also updates the setup-msbuild action to 1.0.2 as 1.0.1 no longer works (this is consistent with other usages of the action in these workflows).
The change to integration_tests.yml removes redundant references to github.workspace (no behaviour change).