Feature/linux x86 dont install if packages exist #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor Author
| Oh no. Looks like debian python apt package does not exist on github runners. Looking at other ways. |
apt python module is not installed on github runners. Instead of adding another dependency, using vanilla python modules to get the job done.
jonsimantov reviewed Dec 10, 2020
jonsimantov approved these changes Dec 11, 2020
Contributor
jonsimantov left a comment
jonsimantov left a comment There was a problem hiding this comment.
LGTM as long as it's okay that gcc-multilib and g++multilib are now installed before the i386 architecture is added.
Contributor Author
| I think you meant that we are installing them after i386 architecture is added, which is different from what we did earlier. |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
For linux x86 builds, we have to install some required i386 packages before proceeding with the build.
This is an optimization to only run these install commands if those packages dont exist already).
Avoids having the user to type in their password everytime as these commands require admin rights.