Added more test phone numbers. #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…/firebase-cpp-sdk into feature/reduce_phone_auth_flake
| What exactly was the underlying issue? Was it that multiple concurrent instances of the integration test were making a request with this phone number and this caused problems? |
Yes, exactly that. |
anonymous-akorn approved these changes Dec 1, 2020
vimanyu approved these changes Dec 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The use of a single phone number caused issues when multiple clients were running in the integration test CI framework. causing the PhoneAuth attempts to globber one another.
Added 9 more phone numbers, and made the choice of the phone number to be random based on the time.