Deduplicate vcpkg logic in testapp builder #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Rely on the vcpkg logic in the build script for the SDK and the utils file instead of duplicating it. The duplicated logic has broken due to a change in the response files: this refactoring will avoid similar issues in the future.
vimanyu approved these changes Nov 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The testapp builder duplicated some vcpkg logic: this removes that duplication, instead relying on build_desktop.py's "vcpkg_step_only" mode, and some logic from utils.py
This fixes a break caused by a change in the structure of the vcpkg response files which was not reflected in this duplicated logic, and will prevent similar breakages in the future.