Skip to content

Conversation

@anonymous-akorn
Copy link
Contributor

NDK_ROOT was being set, but not ANDROID_NDK_HOME, the latter pointing to the VM's default installation of NDK21 or so. This was causing a build failure for the integration tests.

It was setting NDK_ROOT, but not ANDROID_NDK_HOME, the latter pointing to the VM's default installation of NDK21 or so.
jonsimantov
jonsimantov previously approved these changes Oct 28, 2020
@anonymous-akorn
Copy link
Contributor Author

Looks like this doesn't quite work properly on Windows.

install_prereqs.sh downloads the NDK to a UNIX path "/tmp/...", which translates to something very different on Windows (C:\Users<user>\AppData...). But when I set an env var in the workflow file to that, it does not get translated to such a path, so the NDK isn't found on Windows. Going to test a different way to set the env vars.

Didn't run into the issue previously since it was apparently using the default value for ANDROID_NDK_HOME, which pointed to a valid path for the NDK already on the VM.

install_prereqs.sh is a bash script that downloads the ndk to /tmp/..., which gets translated to a different path on Windows. Setting the env var in the workflow file did not appear to cause a similar transformation. So instead we export the env vars using bash to mimick the effect.
@jonsimantov
Copy link
Contributor

Looks like this doesn't quite work properly on Windows.

install_prereqs.sh downloads the NDK to a UNIX path "/tmp/...", which translates to something very different on Windows (C:\Users\AppData...). But when I set an env var in the workflow file to that, it does not get translated to such a path, so the NDK isn't found on Windows. Going to test a different way to set the env vars.

Didn't run into the issue previously since it was apparently using the default value for ANDROID_NDK_HOME, which pointed to a valid path for the NDK already on the VM.

There are a number of Windows Android issues, I believe @vimanyu was considering disabling the Windows Android workflows and making it a separate task to get it working again.

@jonsimantov
Copy link
Contributor

Also, with the change I merged into dev, it should actually build now if you stop setting ANDROID_NDK_HOME (it shouldn't try to build those alternate ABIs with the default NDK) which might be sufficient for now.

@anonymous-akorn anonymous-akorn deleted the feature/aks-fix-env-var branch October 29, 2020 22:43
@firebase firebase locked and limited conversation to collaborators Nov 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

2 participants