Skip to content

fix storage integration testapp for iOS #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 23, 2020
Merged

fix storage integration testapp for iOS #170

merged 6 commits into from
Oct 23, 2020

Conversation

@sunmou99
Copy link
Contributor

@sunmou99 sunmou99 commented Oct 19, 2020 •
edited
Loading

I believe this commit causing the iOS test fail: 3ece8b2 @DellaBitta

And I was wondering if should we sync the changes into google3.
@sunmou99 sunmou99 changed the title fix storage integration testapp for mobile fix storage integration testapp for iOS Oct 20, 2020
@google-cla google-cla bot added the cla: yes label Oct 20, 2020
@DellaBitta
Copy link
Contributor

What aspect of the test is broken by the prior change? Also there were multiple locations where I replaced a simple timed wait with a tight loop waiting for data to be sent. Does this change need to be made at all of those other locations, too?
@sunmou99
Copy link
Contributor Author

sunmou99 commented Oct 22, 2020 •
edited
Loading

What aspect of the test is broken by the prior change?

It breaks FirebaseStorageTest.TestLargeFilePauseResumeAndDownloadCancel in iOS.

Also there were multiple locations where I replaced a simple timed wait with a tight loop waiting for data to be sent. Does this change need to be made at all of those other locations, too?

I don't think so. Some locations doesn't affect Mobile Platform, and others doesn't break the mobile tests. I believe this is the only place need to change. iOS tests passed after the change.
@anonymous-akorn
Copy link
Contributor

Additional context in b/171415295

Is it possible this is also causing the issues for Android?
@sunmou99
Copy link
Contributor Author

sunmou99 commented Oct 23, 2020 •
edited
Loading

Is it possible this is also causing the issues for Android?

I don't think so. 3ece8b2 has nothing to do with 'FirebaseStorageTest.TestDeleteFile'. Also, I don't see an issue on Android. The Android (Mac) tests passed on dev branch.
@DellaBitta
Copy link
Contributor

I verified the test on Android as well. Great!
@sunmou99 sunmou99 merged commit e604ac7 into dev Oct 23, 2020
@sunmou99 sunmou99 deleted the feature/fix-storage-testapp branch October 23, 2020 18:14
@firebase firebase locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes

3 participants

@sunmou99 @DellaBitta @anonymous-akorn