Upload desktop integration artifacts to GCS #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
We can't expose these artifacts in Github workflows, as that would expose secrets: in order to run a desktop integration test it's necessary to have the decrypted google-services.json file. This script thus uploads desktop artifacts (the integration test binaries, and the google services json) to GCS instead. To avoid duplication with the existing test_lab.py tool, common functionality has been moved into integration_testing/gcs.py
It seems "!cancelled()" works in compound conditions, but not in isolation. Need to use the explicit {{ !cancelled() }} syntax when the status function is the only item in the condition. 
Python 3.9 is incompatible with the Google Cloud SDK at the moment. It supports 3.6-3.8, so we pin to 3.7 to be consistent with the version of Pytohn used by the workflows that build the Firebase SDK.
vimanyu requested changes Oct 19, 2020
DellaBitta requested changes Oct 20, 2020
| Consider adapting this presubmit test - https://github.com/firebase/firebase-ios-sdk/blob/master/scripts/check_copyright.sh |
| Yep, thanks! It's on our list of things to do! |
- Move relative_path_to_gs_uri to shared library gcs.py, and have it return paths unmodified if they're already gs uris. - Replace Windows path separators in test_lab.py when declaring results directory for mobile integration tests, to avoid issues when trying to download artifacts on Mac/Linux. - Use os.path.relpath instead of custom logic that does the same thing.
| Well that's new: |
DellaBitta approved these changes Oct 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This creates a python script to upload artifacts to GCS, and adds a step to the integration test workflow to run it.
We can't expose these artifacts in Github workflows, as that would expose secrets: in order to run a desktop integration test it's necessary to have the decrypted google-services.json file. This script thus uploads desktop artifacts (the integration test binaries, and the google services json) to GCS instead.
To avoid duplication with the existing test_lab.py tool, common functionality has been moved into the new library file integration_testing/gcs.py
At the end of the workflow step to upload artifacts, it will report this:
Use 'gsutil cp <gs_uri> <local_path> to copy an artifact locally.
Use 'gsutil -m cp -r gs://games-auto-release-testing/201013-231404_ckjT <local_path> to copy everything.
This can be used to download artifacts for local testing/inspection. This requires the cloud sdk to be installed locally, to use the gsutil tool.