Continue work on packaging: Android and iOS done, Linux done, Mac done, Windows done (though still need /MD and /MT build pair). #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Vcpkg ships with few prebuilt configurations and for any custom build configs, we have to create new vcpkg files. These changes take care of creating necessary files for vcpkg before building.
Prints out cmake options that should be used to point to libs built with vcpkg.
and a build option to set Android STL (not yet used).
…ktop build script, and enable this option on both iOS and MacOS.
…irebase-cpp-sdk into feature/js-packaging2
… included in the final package.
"downloadLiveVersion" not yet used.
vimanyu requested changes Oct 26, 2020
a-maurice reviewed Oct 26, 2020
…d put the variable in the top-level CMake file.
a-maurice approved these changes Oct 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Modify packaging workflows a bit to add all 3 Android STLs (using NDK r16), and rely on the new iOS build script to build the universal frameworks.
Add a step that gathers all the built artifacts. Mobile artifacts are packaged correctly, but desktop is not yet working as it requires postprocessing the libraries using the merge_libraries script.