Skip to content

Fix firestore ios build #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 10, 2020
Merged

Fix firestore ios build #157

merged 3 commits into from
Oct 10, 2020

Conversation

@sunmou99
Copy link
Contributor

@sunmou99 sunmou99 commented Oct 7, 2020

There are 3 reason causing the firestore ios integration testapp not build:

  1. pod version (6.24.0 -> 6.32.2)
  2. firestore library missing source files (at least for iOS Framework)
  3. firestore api updated

Also, I believe we should update all /integration_test/Podfile as well. But that should be another PR. Is there a strategy to update /integration_test/Podfile after the /ios_pod/Podfile updated?
@google-cla google-cla bot added the cla: yes label Oct 7, 2020
@sunmou99 sunmou99 changed the title fix firestore ios build Fix firestore ios build Oct 7, 2020
@sunmou99 sunmou99 merged commit 49456ee into dev Oct 10, 2020
@sunmou99 sunmou99 deleted the feature/fix-firestore-ios-build branch October 10, 2020 02:18
@firebase firebase locked and limited conversation to collaborators Nov 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes

2 participants

@sunmou99 @a-maurice