Skip to content

Conversation

@jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Mar 27, 2024

Description

Provide details of the change, and generalize the change in the PR title above.

Our REST implementation has a default timeout of 5 minutes. This overrides this timeout with 0, which tells libcurl to have no timeout for the connection.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Integration tests in this PR.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Mar 27, 2024
@github-actions
Copy link

github-actions bot commented Mar 27, 2024

❌  Integration test FAILED

Requested by @jonsimantov on commit 3020c59
Last updated: Fri Mar 29 17:21 PDT 2024
View integration test log & download artifacts

Failures Configs
database [TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(2 failed tests)  FirebaseDatabaseTest.TestSetAndGetSimpleValues
  FirebaseDatabaseTest.TestUpdateChildren
firestore [BUILD] [ERROR] [MacOS] [x64] [openssl]
[TEST] [ERROR] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
[TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(6 failed tests)  ServerTimestampTest.TestServerTimestampsCanReturnEstimatedValue
  ServerTimestampTest.TestServerTimestampsCanReturnPreviousValue
  ServerTimestampTest.TestServerTimestampsWorkViaSet
  ServerTimestampTest.TestServerTimestampsWorkViaTransactionSet
  ServerTimestampTest.TestServerTimestampsWorkViaTransactionUpdate
  ServerTimestampTest.TestServerTimestampsWorkViaUpdate
storage [TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(1 failed tests)  FirebaseStorageTest.TestWriteAndReadFileWithCustomMetadata

Add flaky tests to go/fpl-cpp-flake-tracker

@jonsimantov jonsimantov requested a review from a-maurice March 27, 2024 17:48
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Mar 27, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Mar 27, 2024
@jonsimantov jonsimantov merged commit 3020c59 into main Mar 29, 2024
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: succeeded This PR's integration tests succeeded. labels Mar 29, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Mar 30, 2024
@firebase firebase locked and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tests: failed This PR's integration tests failed.

2 participants