Skip to content

Feature/cmake ios framework #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Oct 6, 2020
Merged

Feature/cmake ios framework #154

merged 13 commits into from
Oct 6, 2020

Conversation

@sunmou99
Copy link
Contributor

@sunmou99 sunmou99 commented Oct 6, 2020

Currently, CMake builds library for iOS. This PR modifies the CMake to build Framework for iOS.

The build cmd is the same as it use to be.

Design Doc
@sunmou99 sunmou99 requested a review from a-maurice October 6, 2020 00:38
@google-cla google-cla bot added the cla: yes label Oct 6, 2020
@sunmou99 sunmou99 requested a review from jonsimantov October 6, 2020 04:30
a-maurice
a-maurice approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@a-maurice a-maurice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might be a better way to do the headers, but this is a good start.
@sunmou99 sunmou99 merged commit ba07b51 into dev Oct 6, 2020
@sunmou99 sunmou99 deleted the feature/cmake-ios-framework branch October 6, 2020 21:04
@firebase firebase locked and limited conversation to collaborators Nov 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes

2 participants

@sunmou99 @a-maurice