Skip to content

Build & Test unsigned iOS integration test against repo #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 47 commits into from
Oct 12, 2020
Merged

Build & Test unsigned iOS integration test against repo #148

merged 47 commits into from
Oct 12, 2020

Conversation

@sunmou99
Copy link
Contributor

@sunmou99 sunmou99 commented Sep 17, 2020 •
edited
Loading

Workflow to build & test iOS integration test

  • add build iOS framework against repo
  • change to build unsigned .ipa and delete signing code.
  • build vcpkg only for Desktop platform
  • fix bug b/163338992
  • exclude [iOS,ubuntu-latest] [iOS,windows-latest] from matrix
  • install gcloud components "beta"
  • add function to set bundle id.
@anonymous-akorn
Copy link
Contributor

Could you add some context on this PR? It looks like you're merging one of your feature branches into another one of your feature branches, which doesn't require approval. Are you just looking for some early input on these particular changes?
@sunmou99
Copy link
Contributor Author

Talked with akorn about the context on this PR.
anonymous-akorn
anonymous-akorn suggested changes Sep 18, 2020
View reviewed changes
Copy link
Contributor

@anonymous-akorn anonymous-akorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good at a high level.
@sunmou99 sunmou99 force-pushed the feature/package-ios-frameworks branch from 1dc32a5 to a18b8d3 Compare September 26, 2020 00:46
@sunmou99 sunmou99 force-pushed the feature/gha-ios-integration-tests branch 2 times, most recently from 2a4a521 to 7a28586 Compare September 26, 2020 09:09
@sunmou99 sunmou99 force-pushed the feature/package-ios-frameworks branch from f44a97d to 099b6d6 Compare September 26, 2020 17:57
@sunmou99
parent 93235d7
5e5416e 
author Mou Sun <69009538+sunmou99@users.noreply.github.com> 1600235390 -0700 committer Mou <sunmou@google.com> 1601144485 -0700 Update build script & add iOS GHA workflow
@sunmou99 sunmou99 force-pushed the feature/gha-ios-integration-tests branch from 437cff8 to 5e5416e Compare September 26, 2020 18:26
anonymous-akorn
anonymous-akorn suggested changes Oct 7, 2020
View reviewed changes
@sunmou99 sunmou99 changed the title Build iOS integration test against repo & workflow Build & Test iOS integration test against repo Oct 9, 2020
anonymous-akorn
anonymous-akorn suggested changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@anonymous-akorn anonymous-akorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a merge conflict? Also some of these files look fairly outdated, like they're missing changes from dev. Might need to merge from dev.
@sunmou99
Copy link
Contributor Author

sunmou99 commented Oct 9, 2020 •
edited
Loading

Looks like there's a merge conflict? Also some of these files look fairly outdated, like they're missing changes from dev. Might need to merge from dev.

@anonymous-akorn
Yes. I noticed it too. But I have resolved the merge conflict more than 3 times. So, I decide not to resolve it until feature/package-ios-frameworks get merged.
The files are rebased/merge from dev this Monday, not quite outdated. Again, I will rebased/merge from dev after feature/package-ios-frameworks get merged.
Base automatically changed from feature/package-ios-frameworks to dev October 10, 2020 02:17
@sunmou99 sunmou99 merged commit 3a5cedc into dev Oct 12, 2020
@sunmou99 sunmou99 deleted the feature/gha-ios-integration-tests branch October 12, 2020 23:09
@firebase firebase locked and limited conversation to collaborators Nov 12, 2020
@sunmou99 sunmou99 changed the title Build & Test iOS integration test against repo Build & Test unsigned iOS integration test against repo Mar 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes

3 participants

@sunmou99 @anonymous-akorn @googlebot