-   Notifications  
You must be signed in to change notification settings  - Fork 125
 
Add script that build iOS frameworks build #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5d26d65 to 1dc32a5   Compare   There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very clean overall!
 Super minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be worth sync'ing up with the iCore team before going too far on developing scripts to generate frameworks. Apple is deprecating frameworks in favor of xcframeworks with the onset of Catalyst and arm64 macs.
It also might make sense to collaborate more on tooling since we already have some tooling for transforming Firebase sources to binaries at https://github.com/firebase/firebase-ios-sdk/tree/master/ZipBuilder
|   @paulb777 Thanks for calling out.  |  
cdef37e to 1dc32a5   Compare   1dc32a5 to a18b8d3   Compare   f44a97d to 099b6d6   Compare   …irebase/firebase-cpp-sdk into feature/package-ios-frameworks
…irebase/firebase-cpp-sdk into feature/package-ios-frameworks
Added ios build script (replaced the old one). The generated frameworks locate at dir "/ios_build" by default.
Added ios build workflow.
Tried to build different architectures in parallel, but it's more likely to break.
10/06/2020 update:
Build different architectures in parallel, build time reduced from ~33 minutes to ~20 minutes.