Skip to content

Conversation

@sunmou99
Copy link
Contributor

@sunmou99 sunmou99 commented Sep 17, 2020

Added ios build script (replaced the old one). The generated frameworks locate at dir "/ios_build" by default.
Added ios build workflow.

Tried to build different architectures in parallel, but it's more likely to break.

10/06/2020 update:
Build different architectures in parallel, build time reduced from ~33 minutes to ~20 minutes.

@sunmou99 sunmou99 changed the title Add ios frameworks build Add iOS frameworks build Sep 17, 2020
@sunmou99 sunmou99 force-pushed the feature/package-ios-frameworks branch 4 times, most recently from 5d26d65 to 1dc32a5 Compare September 17, 2020 22:00
Copy link
Contributor

@vimanyu vimanyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very clean overall!
Super minor comments.

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be worth sync'ing up with the iCore team before going too far on developing scripts to generate frameworks. Apple is deprecating frameworks in favor of xcframeworks with the onset of Catalyst and arm64 macs.

It also might make sense to collaborate more on tooling since we already have some tooling for transforming Firebase sources to binaries at https://github.com/firebase/firebase-ios-sdk/tree/master/ZipBuilder

@sunmou99 sunmou99 changed the base branch from feature/cmake-ios-framework to dev September 25, 2020 22:45
@sunmou99 sunmou99 changed the base branch from dev to feature/cmake-ios-framework September 25, 2020 22:45
@sunmou99
Copy link
Contributor Author

@paulb777 Thanks for calling out.
I talked with Gran, it seems that ZipBuilder is not the tool we could use here.
xcframeworks sounds good, but CMake doesn't support xcframeworks. Also, I don't know if xcframeworks will affect the test codes.
Who (from iCore) should I reach out to for more information?

@sunmou99 sunmou99 force-pushed the feature/package-ios-frameworks branch from cdef37e to 1dc32a5 Compare September 26, 2020 00:24
@sunmou99 sunmou99 force-pushed the feature/package-ios-frameworks branch from 1dc32a5 to a18b8d3 Compare September 26, 2020 00:46
@sunmou99 sunmou99 force-pushed the feature/package-ios-frameworks branch from f44a97d to 099b6d6 Compare September 26, 2020 17:57
@sunmou99 sunmou99 changed the base branch from feature/cmake-ios-framework to dev October 6, 2020 00:26
@sunmou99 sunmou99 dismissed a-maurice’s stale review October 6, 2020 00:26

The base branch was changed.

@sunmou99 sunmou99 changed the base branch from dev to feature/cmake-ios-framework October 6, 2020 00:40
@sunmou99 sunmou99 changed the base branch from feature/cmake-ios-framework to dev October 6, 2020 21:01
@sunmou99 sunmou99 changed the base branch from dev to feature/cmake-ios-framework October 6, 2020 21:02
Base automatically changed from feature/cmake-ios-framework to dev October 6, 2020 21:04
@sunmou99 sunmou99 requested a review from a-maurice October 8, 2020 23:08
@sunmou99 sunmou99 merged commit e2c94f8 into dev Oct 10, 2020
@sunmou99 sunmou99 deleted the feature/package-ios-frameworks branch October 10, 2020 02:17
@firebase firebase locked and limited conversation to collaborators Nov 10, 2020
@sunmou99 sunmou99 changed the title Add iOS frameworks build Add script that build iOS frameworks build Feb 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

5 participants