Skip to content

Conversation

cherylEnkidu
Copy link
Contributor

Restore PR: #5626

The majority of the code in this PR was contributed by vladd-g

For more context, please refer to the linked PR.

Copy link
Contributor

github-actions bot commented Feb 12, 2024

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 12, 2024

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.13% (1140948) to 50.12% (6bf7926) by -0.01%.

    FilenameBase (1140948)Merge (6bf7926)Diff
    CustomClassMapper.java88.33%88.52%+0.19%
    QueryParams.java90.36%89.76%-0.60%
    ViewProcessor.java91.79%92.10%+0.30%
    WebsocketConnection.java35.03%32.77%-2.26%
  • firebase-firestore

    Overall coverage changed from 44.84% (1140948) to 44.86% (6bf7926) by +0.02%.

    FilenameBase (1140948)Merge (6bf7926)Diff
    CustomClassMapper.java84.25%84.44%+0.19%
    DeleteMutation.java90.48%95.24%+4.76%
    SetMutation.java94.44%97.22%+2.78%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/oGvSUwtxPK.html
Copy link
Contributor

github-actions bot commented Feb 12, 2024

Unit Test Results

   250 files  +   210     250 suites  +210   5m 10s ⏱️ + 3m 54s
1 644 tests +1 334  1 626 ✔️ +1 316  18 💤 +18  0 ±0 
3 338 runs  +2 706  3 302 ✔️ +2 670  36 💤 +36  0 ±0 

Results for commit f027327. ± Comparison against base commit 1140948.

This pull request removes 310 and adds 1644 tests. Note that renamed tests count towards both.
com.google.firebase.remoteconfig.ConfigTests ‑ Firebase#remoteConfig should delegate to FirebaseRemoteConfig#getInstance() com.google.firebase.remoteconfig.ConfigTests ‑ Firebase#remoteConfig should delegate to FirebaseRemoteConfig#getInstance(FirebaseApp, region) com.google.firebase.remoteconfig.ConfigTests ‑ FirebaseRemoteConfigSettings builder works com.google.firebase.remoteconfig.ConfigTests ‑ Overloaded get() operator returns default value when key doesn't exist com.google.firebase.remoteconfig.ConfigTests ‑ Overloaded get() operator returns value when key exists com.google.firebase.remoteconfig.FirebaseRemoteConfigSettingsTest ‑ toBuilder_withFieldsSet_buildsObjectWithFieldsSet com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate2p_hasAbtExperiments_doesNotCallAbt com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate2p_hasNoAbtExperiments_doesNotCallAbt com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate_callToAbtFails_activateStillSucceeds com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate_configWithRolloutMetadata_storedInActivatedCacheSuccessfully … 
com.google.firebase.TimestampTest ‑ testCompare com.google.firebase.TimestampTest ‑ testFromDate com.google.firebase.TimestampTest ‑ testRejectBadDates com.google.firebase.TimestampTest ‑ testTimestampParcelable com.google.firebase.database.DataSnapshotTest ‑ basicIterationWorks com.google.firebase.database.DataSnapshotTest ‑ existsWorks com.google.firebase.database.DataSnapshotTests ‑ reified getValue works with basic types com.google.firebase.database.DataSnapshotTests ‑ reified getValue works with custom types com.google.firebase.database.DataSnapshotTests ‑ reified getValue works with lists types com.google.firebase.database.DataSnapshotTests ‑ reified getValue works with maps … 

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 12, 2024

Size Report 1

Affected Products

  • firebase-database

    TypeBase (1140948)Merge (6bf7926)Diff
    aar537 kB537 kB+120 B (+0.0%)
    apk (release)5.39 MB5.40 MB+96 B (+0.0%)
  • firebase-firestore

    TypeBase (1140948)Merge (6bf7926)Diff
    aar1.41 MB1.41 MB+137 B (+0.0%)
    apk (release)11.4 MB11.4 MB+100 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/2JgXZKIhez.html
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 12, 2024

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-fst

    DeviceStatisticsDistributions
    oriole-32
    Percentile11409486bf7926DiffSignificant (?)
    p10580 ±256 μs320 ±18 μs-260 μs (-44.8%)NO
    p25608 ±258 μs335 ±22 μs-273 μs (-45.0%)NO
    p50658 ±246 μs373 ±55 μs-284 μs (-43.2%)NO
    p75718 ±225 μs457 ±105 μs-260 μs (-36.3%)NO
    p90816 ±214 μs613 ±233 μs-203 μs (-24.8%)NO

    20 test runs in comparison
    CommitTest Runs
    1140948
    • 2024-02-14_16:55:45.174079_Cwyz
    • 2024-02-14_16:55:45.174124_zYcN
    • 2024-02-14_16:55:45.174136_yoOx
    • 2024-02-14_16:55:45.174145_aTNg
    • 2024-02-14_16:55:45.174154_FcFA
    • 2024-02-14_16:55:45.174163_Tqgl
    • 2024-02-14_16:55:45.174180_WkqB
    • 2024-02-14_16:55:45.174187_hvgh
    • 2024-02-14_16:55:45.174194_DDzk
    • 2024-02-14_16:55:45.174201_GcCu
    6bf7926
    • 2024-02-17_05:47:25.081876_KVSf
    • 2024-02-17_05:47:25.081911_iFxZ
    • 2024-02-17_05:47:25.081922_JVFL
    • 2024-02-17_05:47:25.081928_kVOh
    • 2024-02-17_05:47:25.081933_zhmi
    • 2024-02-17_05:47:25.081937_jXgm
    • 2024-02-17_05:47:25.081941_zpYl
    • 2024-02-17_05:47:25.081945_voqa
    • 2024-02-17_05:47:25.081949_InUt
    • 2024-02-17_05:47:25.081953_uEvk
    redfin-30
    Percentile11409486bf7926DiffSignificant (?)
    p10712 ±210 μs604 ±39 μs-107 μs (-15.1%)NO
    p25734 ±208 μs624 ±42 μs-110 μs (-15.0%)NO
    p50763 ±203 μs657 ±52 μs-106 μs (-13.9%)NO
    p75810 ±203 μs696 ±61 μs-114 μs (-14.1%)NO
    p90876 ±208 μs760 ±87 μs-116 μs (-13.3%)NO

    20 test runs in comparison
    CommitTest Runs
    1140948
    • 2024-02-14_16:55:45.174079_Cwyz
    • 2024-02-14_16:55:45.174124_zYcN
    • 2024-02-14_16:55:45.174136_yoOx
    • 2024-02-14_16:55:45.174145_aTNg
    • 2024-02-14_16:55:45.174154_FcFA
    • 2024-02-14_16:55:45.174163_Tqgl
    • 2024-02-14_16:55:45.174180_WkqB
    • 2024-02-14_16:55:45.174187_hvgh
    • 2024-02-14_16:55:45.174194_DDzk
    • 2024-02-14_16:55:45.174201_GcCu
    6bf7926
    • 2024-02-17_05:47:25.081876_KVSf
    • 2024-02-17_05:47:25.081911_iFxZ
    • 2024-02-17_05:47:25.081922_JVFL
    • 2024-02-17_05:47:25.081928_kVOh
    • 2024-02-17_05:47:25.081933_zhmi
    • 2024-02-17_05:47:25.081937_jXgm
    • 2024-02-17_05:47:25.081941_zpYl
    • 2024-02-17_05:47:25.081945_voqa
    • 2024-02-17_05:47:25.081949_InUt
    • 2024-02-17_05:47:25.081953_uEvk
  • fire-rtdb

    DeviceStatisticsDistributions
    oriole-32
    Percentile11409486bf7926DiffSignificant (?)
    p1032.5 ±4 μs36.2 ±7 μs+3.73 μs (+11.5%)NO
    p2537.4 ±9 μs39.1 ±8 μs+1.69 μs (+4.5%)NO
    p50139 ±209 μs44.6 ±12 μs-94.8 μs (-68.0%)NO
    p75153 ±214 μs53.5 ±20 μs-99.6 μs (-65.0%)NO
    p90173 ±221 μs76.5 ±44 μs-96.6 μs (-55.8%)NO

    20 test runs in comparison
    CommitTest Runs
    1140948
    • 2024-02-14_16:55:45.174079_Cwyz
    • 2024-02-14_16:55:45.174124_zYcN
    • 2024-02-14_16:55:45.174136_yoOx
    • 2024-02-14_16:55:45.174145_aTNg
    • 2024-02-14_16:55:45.174154_FcFA
    • 2024-02-14_16:55:45.174163_Tqgl
    • 2024-02-14_16:55:45.174180_WkqB
    • 2024-02-14_16:55:45.174187_hvgh
    • 2024-02-14_16:55:45.174194_DDzk
    • 2024-02-14_16:55:45.174201_GcCu
    6bf7926
    • 2024-02-17_05:47:25.081876_KVSf
    • 2024-02-17_05:47:25.081911_iFxZ
    • 2024-02-17_05:47:25.081922_JVFL
    • 2024-02-17_05:47:25.081928_kVOh
    • 2024-02-17_05:47:25.081933_zhmi
    • 2024-02-17_05:47:25.081937_jXgm
    • 2024-02-17_05:47:25.081941_zpYl
    • 2024-02-17_05:47:25.081945_voqa
    • 2024-02-17_05:47:25.081949_InUt
    • 2024-02-17_05:47:25.081953_uEvk
    redfin-30
    Percentile11409486bf7926DiffSignificant (?)
    p1071.5 ±12 μs80.9 ±15 μs+9.41 μs (+13.2%)NO
    p2576.2 ±11 μs84.9 ±14 μs+8.75 μs (+11.5%)NO
    p5083.7 ±10 μs91.3 ±14 μs+7.64 μs (+9.1%)NO
    p7594.1 ±10 μs101 ±13 μs+6.73 μs (+7.2%)NO
    p90121 ±29 μs119 ±14 μs-1.44 μs (-1.2%)NO

    20 test runs in comparison
    CommitTest Runs
    1140948
    • 2024-02-14_16:55:45.174079_Cwyz
    • 2024-02-14_16:55:45.174124_zYcN
    • 2024-02-14_16:55:45.174136_yoOx
    • 2024-02-14_16:55:45.174145_aTNg
    • 2024-02-14_16:55:45.174154_FcFA
    • 2024-02-14_16:55:45.174163_Tqgl
    • 2024-02-14_16:55:45.174180_WkqB
    • 2024-02-14_16:55:45.174187_hvgh
    • 2024-02-14_16:55:45.174194_DDzk
    • 2024-02-14_16:55:45.174201_GcCu
    6bf7926
    • 2024-02-17_05:47:25.081876_KVSf
    • 2024-02-17_05:47:25.081911_iFxZ
    • 2024-02-17_05:47:25.081922_JVFL
    • 2024-02-17_05:47:25.081928_kVOh
    • 2024-02-17_05:47:25.081933_zhmi
    • 2024-02-17_05:47:25.081937_jXgm
    • 2024-02-17_05:47:25.081941_zpYl
    • 2024-02-17_05:47:25.081945_voqa
    • 2024-02-17_05:47:25.081949_InUt
    • 2024-02-17_05:47:25.081953_uEvk
  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentile11409486bf7926DiffSignificant (?)
    p10204 ±5 ms208 ±3 ms+4.52 ms (+2.2%)NO
    p25211 ±5 ms215 ±3 ms+4.21 ms (+2.0%)NO
    p50218 ±6 ms223 ±2 ms+4.64 ms (+2.1%)NO
    p75226 ±7 ms233 ±3 ms+6.85 ms (+3.0%)NO
    p90234 ±7 ms244 ±4 ms+9.36 ms (+4.0%)NO

    20 test runs in comparison
    CommitTest Runs
    1140948
    • 2024-02-14_16:55:45.174079_Cwyz
    • 2024-02-14_16:55:45.174124_zYcN
    • 2024-02-14_16:55:45.174136_yoOx
    • 2024-02-14_16:55:45.174145_aTNg
    • 2024-02-14_16:55:45.174154_FcFA
    • 2024-02-14_16:55:45.174163_Tqgl
    • 2024-02-14_16:55:45.174180_WkqB
    • 2024-02-14_16:55:45.174187_hvgh
    • 2024-02-14_16:55:45.174194_DDzk
    • 2024-02-14_16:55:45.174201_GcCu
    6bf7926
    • 2024-02-17_05:47:25.081876_KVSf
    • 2024-02-17_05:47:25.081911_iFxZ
    • 2024-02-17_05:47:25.081922_JVFL
    • 2024-02-17_05:47:25.081928_kVOh
    • 2024-02-17_05:47:25.081933_zhmi
    • 2024-02-17_05:47:25.081937_jXgm
    • 2024-02-17_05:47:25.081941_zpYl
    • 2024-02-17_05:47:25.081945_voqa
    • 2024-02-17_05:47:25.081949_InUt
    • 2024-02-17_05:47:25.081953_uEvk
    redfin-30
    Percentile11409486bf7926DiffSignificant (?)
    p10250 ±5 ms272 ±5 ms+22.4 ms (+8.9%)MAYBE
    p25256 ±6 ms278 ±5 ms+22.0 ms (+8.6%)MAYBE
    p50265 ±7 ms286 ±4 ms+21.1 ms (+8.0%)NO
    p75275 ±11 ms295 ±5 ms+19.6 ms (+7.1%)NO
    p90286 ±13 ms307 ±8 ms+21.4 ms (+7.5%)NO

    20 test runs in comparison
    CommitTest Runs
    1140948
    • 2024-02-14_16:55:45.174079_Cwyz
    • 2024-02-14_16:55:45.174124_zYcN
    • 2024-02-14_16:55:45.174136_yoOx
    • 2024-02-14_16:55:45.174145_aTNg
    • 2024-02-14_16:55:45.174154_FcFA
    • 2024-02-14_16:55:45.174163_Tqgl
    • 2024-02-14_16:55:45.174180_WkqB
    • 2024-02-14_16:55:45.174187_hvgh
    • 2024-02-14_16:55:45.174194_DDzk
    • 2024-02-14_16:55:45.174201_GcCu
    6bf7926
    • 2024-02-17_05:47:25.081876_KVSf
    • 2024-02-17_05:47:25.081911_iFxZ
    • 2024-02-17_05:47:25.081922_JVFL
    • 2024-02-17_05:47:25.081928_kVOh
    • 2024-02-17_05:47:25.081933_zhmi
    • 2024-02-17_05:47:25.081937_jXgm
    • 2024-02-17_05:47:25.081941_zpYl
    • 2024-02-17_05:47:25.081945_voqa
    • 2024-02-17_05:47:25.081949_InUt
    • 2024-02-17_05:47:25.081953_uEvk

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/JBpKwTobPl/index.html
@cherylEnkidu cherylEnkidu force-pushed the cheryllin/fixBugForBridgeMethod branch from c3d9d4e to 59634fb Compare February 12, 2024 21:42
@cherylEnkidu cherylEnkidu changed the title Fixing broken test for "Handle bridge methods while mapping" PR Fixed the missing handling setter annotations bug Feb 12, 2024
@cherylEnkidu cherylEnkidu requested a review from wu-hui February 12, 2024 22:11
@cherylEnkidu cherylEnkidu assigned cherylEnkidu and unassigned wu-hui Feb 13, 2024
@cherylEnkidu cherylEnkidu requested review from tom-andersen and removed request for wu-hui February 13, 2024 22:21
@cherylEnkidu cherylEnkidu force-pushed the cheryllin/fixBugForBridgeMethod branch 2 times, most recently from bb55dd0 to 9c96f9e Compare February 15, 2024 22:14
@cherylEnkidu cherylEnkidu force-pushed the cheryllin/fixBugForBridgeMethod branch from 9c96f9e to f027327 Compare February 16, 2024 00:50
@cherylEnkidu cherylEnkidu merged commit 833a1cc into master Feb 20, 2024
@cherylEnkidu cherylEnkidu deleted the cheryllin/fixBugForBridgeMethod branch February 20, 2024 14:53
mrober pushed a commit that referenced this pull request Feb 28, 2024
Restore PR: #5626 The majority of the code in this PR was contributed by [vladd-g](https://github.com/vladd-g) For more context, please refer to the linked PR.
@firebase firebase locked and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

4 participants