Skip to content

Fixing broken test for "Handle bridge methods while mapping" PR (#5626) #5705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fixing broken test for "Handle bridge methods while mapping" PR (#5626) #5705

wants to merge 1 commit into from

Conversation

cherylEnkidu
Copy link
Contributor

@cherylEnkidu cherylEnkidu commented Feb 12, 2024 •
edited
Loading

Restore PR: #5626

The majority of the code in this PR was contributed by vladd-g

For more context, please refer to the linked PR.
@firebase firebase deleted a comment from github-actions bot Feb 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.
@google-oss-bot
Copy link
Contributor

Coverage Report 1

This report is too large (66,414 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/huICVDv6SY.html
@github-actions GitHub Actions
Copy link
Contributor

Unit Test Results

   250 files  ±0     250 suites  ±0   5m 5s ⏱️ +4s
1 644 tests +4  1 626 ✔️ +4  18 💤 ±0  0 ❌ ±0 
3 338 runs  +8  3 302 ✔️ +8  36 💤 ±0  0 ❌ ±0 

Results for commit 52abd4e. ± Comparison against base commit a4ca0cb.
@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • base

    TypeBase (a4ca0cb)Merge (28b2a24)Diff
    apk (aggressive)?8.75 kB? (?)
    apk (release)?10.5 kB? (?)

  • firebase-database

    TypeBase (a4ca0cb)Merge (28b2a24)Diff
    aar?537 kB? (?)
    apk (aggressive)?547 kB? (?)
    apk (release)?5.40 MB? (?)

  • firebase-firestore

    TypeBase (a4ca0cb)Merge (28b2a24)Diff
    aar?1.41 MB? (?)
    apk (aggressive)?704 kB? (?)
    apk (release)?11.4 MB? (?)

  • protolite-well-known-types

    TypeBase (a4ca0cb)Merge (28b2a24)Diff
    aar?1.00e+03 kB? (?)
    apk (aggressive)?134 kB? (?)
    apk (release)?1.70 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/JxfkO4pSFx.html
@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Startup time comparison between the CI merge commit (28b2a24) and the base commit (a4ca0cb) are not available.

No macrobenchmark data found for the base commit (a4ca0cb). Analysis for the CI merge commit (28b2a24) can be found at:

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/N9YJcA8fra/index.html
@cherylEnkidu cherylEnkidu deleted the revert-5704-revert-5626-exclude-bridge-methods-from-mapping branch February 12, 2024 18:28
@firebase firebase locked and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

main-merge-ack size/L

2 participants

@cherylEnkidu @google-oss-bot