Add test cases for messaging.WebpushFcmOptions

.pylintrc

@@ -301,7 +301,7 @@ single-line-if-stmt=no
 no-space-check=trailing-comma,dict-separator
 
 # Maximum number of lines in a module
-max-module-lines=1000
+max-module-lines=1200
 
 # String used as indentation unit. This is usually " " (4 spaces) or "\t" (1
 # tab).

firebase_admin/messaging.py

@@ -273,7 +273,7 @@ class WebpushConfig(object):
  data: A dictionary of data fields (optional). All keys and values in the dictionary must be
  strings. When specified, overrides any data fields set via ``Message.data``.
  notification: A ``messaging.WebpushNotification`` to be included in the message (optional).
- fcm_options: A ``messaging.WebpushFcmOptions``. (optional).
+ fcm_options: A ``messaging.WebpushFcmOptions`` (optional).
 
  .. _Webpush Specification: https://tools.ietf.org/html/rfc8030#section-5
  """

tests/test_messaging.py

@@ -616,6 +616,29 @@ def test_invalid_action_icon(self, data):
  assert str(excinfo.value) == 'WebpushNotificationAction.icon must be a string.'
 
 
+class TestWebpushFcmOptionsEncoder(object):
+
+ def _check_fcm_options(self, fcm_options):
+ with pytest.raises(ValueError) as excinfo:
+ check_encoding(messaging.Message(
+ topic='topic', webpush=messaging.WebpushConfig(fcm_options=fcm_options)))
+ return excinfo
+
+ @pytest.mark.parametrize('data', NON_OBJECT_ARGS)
+ def test_invalid_webpush_fcm_options(self, data):
+ with pytest.raises(ValueError) as excinfo:
+ check_encoding(messaging.Message(
+ topic='topic', webpush=messaging.WebpushConfig(fcm_options=data)))
+ expected = 'WebpushConfig.fcm_options must be an instance of WebFcmOptions class.'
+ assert str(excinfo.value) == expected
+
+ @pytest.mark.parametrize('data', NON_STRING_ARGS)
+ def test_invalid_link(self, data):
+ notification = messaging.WebpushFcmOptions(link=data)
+ excinfo = self._check_fcm_options(notification)
+ assert str(excinfo.value) == 'WebpushFcmOptions.link must be a string.'
+
+
 class TestAPNSConfigEncoder(object):
 
  @pytest.mark.parametrize('data', NON_OBJECT_ARGS)