🚨 Fix correct return type for SQLALCHEMY_DATABASE_URI computed field #1721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Replace MultiHostUrl.build() with PostgresDsn.build() to match the PostgresDsn return type annotation and resolve type checker error
| It was initially As an alternative, we may want to change the return type to BTW, I couldn't reproduce the type checker error. What type checker do you use? |
YuriiMotov changed the title SQLALCHEMY_DATABASE_URI computed field Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Replace MultiHostUrl.build() with PostgresDsn.build() to match the PostgresDsn return type annotation and resolve type checker error
Fix for the error: