Skip to content

Conversation

@FDiskas
Copy link
Contributor

@FDiskas FDiskas commented Aug 5, 2021

Introduced engines and nvmrc. This is for development. Currently there was workspaces used in package.json witch is only available on npm7. And npm7 comes with node 15. So in case anybody is using nvm it's easy to switch nvm use to project node version.

Also there was a prettier config within eslint - and it is redundant. The configuration is taken from .prettierrc by default.

Also for some reason test with snapshot was failing. I was using Windows and this could be the reason :/

@yamalight
Copy link
Contributor

Looks good, thanks! 👍

@yamalight yamalight merged commit 7d24457 into exoframejs:v7-rewrite Aug 5, 2021
@FDiskas FDiskas deleted the fix/dependencyes branch August 5, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants