Skip to content

exoframejs/exoframe#218 implementing non-interactive config #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 19, 2019
Merged

exoframejs/exoframe#218 implementing non-interactive config #248

merged 5 commits into from
Jul 19, 2019

Conversation

@SeaLife
Copy link
Contributor

@SeaLife SeaLife commented Jul 19, 2019

No description provided.

@SeaLife SeaLife mentioned this pull request Jul 19, 2019
Closed
7 tasks
@coveralls
Copy link

coveralls commented Jul 19, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 81.176% when pulling b94d640 on SeaLife:master into 3828514 on exoframejs:develop.
yamalight
yamalight requested changes Jul 19, 2019
View reviewed changes
Copy link
Contributor

@yamalight yamalight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly perfect :)
yamalight
yamalight requested changes Jul 19, 2019
View reviewed changes
Copy link
Contributor

@yamalight yamalight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny change and we're good to go!
yamalight
yamalight approved these changes Jul 19, 2019
View reviewed changes
Copy link
Contributor

@yamalight yamalight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Will do a pre-release in a minute :)
@yamalight yamalight merged commit 90ad919 into exoframejs:develop Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@SeaLife @coveralls @yamalight @SeaLife97