ContextLocalSingleton Provider Class #442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
sonthonaxrk force-pushed the context-vars branch from 7bfb66f to 67e89bd Compare 
Contributor Author
| Build is red because of coveralls failing to upload the results. |
sonthonaxrk commented Apr 7, 2021
rmk135 reviewed Apr 8, 2021
rmk135 reviewed Apr 8, 2021
rmk135 reviewed Apr 8, 2021
rmk135 reviewed Apr 8, 2021
Member
rmk135 left a comment
rmk135 left a comment There was a problem hiding this comment.
This looks good. Thanks a lot for the contribution. I left some comments, appreciate if you could take a look. Also please target PR to the develop branch.
sonthonaxrk force-pushed the context-vars branch from 5efc8fd to 5113d93 Compare Contributor Author
| I've made the amends and rebased onto dev. |
sonthonaxrk force-pushed the context-vars branch 3 times, most recently from 5efb8c6 to 6523abc Compare 
sonthonaxrk force-pushed the context-vars branch from 6523abc to aca67c3 Compare Contributor Author
| Fixed the pipeline. |
Contributor Author
| Hey @rmk135 are you still interested in merging this? |
Member
Hey @sonthonaxrk , I do. Merging it now :) |
| Just a heads up that there is no documentation of this provider in the main docs |
Member
| @billcrook , thanks for the heads up. It's still in my backlog, will prioritize it! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is just a preliminary example of how I'd switch to using ContextVars. The advantage of ContextVars is that they actually work when using asyncio. I think it might be worth having a
ContextLocalSingletonand aThreadLocalSingleton. Most people will need aContextLocalSingleton.Things I need to do here. Please add anything I'm missing :)
contextvarslibrary to the dependencies so we can support earlier Python 3 versions.Thanks for all your work on this library.