Set body for GET requests when using Curb. #3
Conversation
This fixes a serious issue when sending GET requests to Curb transport backend. Basically request body was discarded and not used at all. For example any search would yield default search - returning all docs.
| Seems that the TravisCI builds are failing randomly on testcases i've never touched, not sure if this is my fault. |
There was a problem hiding this comment.
HEAD requests are supported with Curb, right, why disable them?
There was a problem hiding this comment.
DELETE requests are supported with Curb, just not without body. We need to do more acrobatics here, and check if the request has a body (eg. delete_by_query), then raise an exception, otherwise perform a DELETE request.
There was a problem hiding this comment.
@karmi I've not disabled HEAD I've just moved the actual request call down - see line 31. However DELETE with body seems to be still a problem. I am curious why the tests are green - I suppose curb transport is not tested in integration suite right?
This fix exploits put_data= in Curl::Easy to allow request body for GET, DELETE requests.
| I've managed to exploit Oh, and Curl::Easy.http uses an upcase symbol. That was really nasty. |
2 participants
This fixes a serious issue when sending GET requests to Curb transport backend. Basically request body was discarded and not used at all. For example any search would yield default search - returning all docs.