Skip to content

Conversation

@LancerComet
Copy link

@LancerComet LancerComet commented Dec 27, 2016

// In app.js ... const keepItSecret = true // Now a password is require to access this docsify :) ...
@QingWei-Li
Copy link
Member

QingWei-Li commented Dec 27, 2016

Thank you for your Pull Request.

I have two questions.

  • Why move lib/ folder to public/? It will break the current use.
  • How do we use this feature in GitHub Pages?

However, i like the idea. 😄

@LancerComet
Copy link
Author

@QingWei-Li 🎈🎅

  1. Sorry for doing that, I just want to have a folder to store static files.
  2. This feature is intended to be used in local server, I didn't expect to use it on github, what a shame!😂😂
@QingWei-Li
Copy link
Member

QingWei-Li commented Dec 27, 2016

Maybe we should add this feature into docsify-cli, not here.

But I don't understand why need password in local server.

@LancerComet
Copy link
Author

@QingWei-Li
In my case, I run docsify on an open server but I just want people who have password can get access to our docs.

@QingWei-Li
Copy link
Member

cool!

Move the feature to docsify-cli, what do you think? We can add a command that enable HTTP authentication. such as https://github.com/zeit/serve#authentication

@LancerComet
Copy link
Author

@QingWei-Li
Cool, I will go to check it later 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants