Add page parameter to /admin/users/list API #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Related to discourse/discourse#4866, document the `page` parameter. I also noted that several of the parameters were marked as in `path`, but I believe these should be in `query`... if I'm wrong, and these need to be `path` for some reason, just let me know and I'll roll them back. But, FWIW, when I try using the API myself, those values only seem to work when in the querystring.
| can you take a look @oblakeerickson |
| @JaredReisinger I think you are right about the 'query' option. Thanks! |
| Hmmm, but they don't show up in the docs like the 'path' params do. I'll have to investigate and see why. |
| When I run
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Related to discourse/discourse#4866, document the
pageparameter.I also noted that several of the parameters were marked as in
path, but I believe these should be inquery... if I'm wrong, and these need to bepathfor some reason, just let me know and I'll roll them back. But, FWIW, when I try using the API myself, those values only seem to work when in the querystring.