DEV: add migration to update deprecated icons in settings #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
tyb-talks force-pushed the dev-update-deprecated-icons-in-settings branch from 1d4454c to 7f0f65d Compare 
tyb-talks commented Mar 11, 2025
Comment on lines +24 to +26
| if (parts[1].toLowerCase() === "divider") { | ||
| return item; | ||
| } |
There was a problem hiding this comment.
early return here to mirror the same setting parsing logic at
.
davidtaylorhq approved these changes Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR does a setting migration for deprecated icon names. For more detail, refer to the announcement at https://meta.discourse.org/t/-/325349.