Add a locale filter to links #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 2 commits March 23, 2023 12:32
This attribute is to be set to a language code like 'fr', 'en' or 'de'.
| Hello ! As per the effort of the forum we're currently holding, and to allow localization, we've added an attribute "locale" to links, which allows filtering of links according to the HTML's lang attribute ! For instance, if the link has "fr" tag for the french page, but the browser client has the english as default, then the link will not be pushed to the site's HTML :) Thank you in advance for revieweing ! |
jordanvidrine approved these changes Apr 21, 2023
Arkshine added a commit to Arkshine/discourse-custom-header-links that referenced this pull request Apr 22, 2023
Related discourse#30. Reported here: https://meta.discourse.org/t/missing-custom-header-links-after-update/262594 #### Current behavior The links are not displayed if a locale is not provided in the setting. #### Expected behavior By not associating a locale with a link, the link should be displayed by default regardless of the user's language.
Arkshine added a commit to Arkshine/discourse-custom-header-links that referenced this pull request Apr 22, 2023
Related discourse#30. Reported here: https://meta.discourse.org/t/missing-custom-header-links-after-update/262594 #### Current behavior The links are not displayed if a locale is not provided in the setting. #### Expected behavior By not associating a locale with a link, the link should be displayed by default regardless of the user's language.
jordanvidrine pushed a commit that referenced this pull request Apr 24, 2023
#31) Related #30. Reported here: https://meta.discourse.org/t/missing-custom-header-links-after-update/262594 #### Current behavior The links are not displayed if a locale is not provided in the setting. #### Expected behavior By not associating a locale with a link, the link should be displayed by default regardless of the user's language.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.