Skip to content

Conversation

@hnb-ku
Copy link
Contributor

@hnb-ku hnb-ku commented May 4, 2019

This PR includes the following implementation improvements

  1. internal links will no longer cause a full page reload
  2. <li> items are now wrapped in a <ul> many thanks for that @discoursehosting
  3. each link will have a unique CSS class added to it based on its text.
  4. Leaving the component settings empty will not cause any issues.
@hnb-ku hnb-ku merged commit 175a027 into master May 4, 2019
@hnb-ku hnb-ku deleted the implementation-improvements branch May 4, 2019 15:42
notstephen added a commit to notstephen/discourse-custom-header-links that referenced this pull request May 4, 2019
sylque added a commit to sylque/discourse-custom-header-links2 that referenced this pull request May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants