feat: add leaderboard feature with language dropdown and entries table #3060
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| export default class LeaderboardPageEntriesTableRow extends Component<Signature> { | ||
| get isCurrentUser(): boolean { | ||
| return this.args.entry.user.username === 'ry'; | ||
| } |
There was a problem hiding this comment.
Bug: Hardcoded Username Causes Incorrect Highlighting
The isCurrentUser getter hardcodes the username 'ry' instead of comparing against the actual authenticated user. This means only the 'ry' user's row will be highlighted, regardless of who is logged in. This looks like development code that was accidentally committed.
| | ||
| return { | ||
| language: language, | ||
| leaderboard: leaderboards[0]!, // TODO: Support actual filter of leaderboards |
There was a problem hiding this comment.
Bug: Model Hook Fails with Non-Null Assertions
The model hook uses non-null assertions (!) when finding a language by slug and accessing leaderboards[0]. If no language matches the provided slug or the leaderboards array is empty, these assertions will cause runtime errors.
| <LeaderboardPage::EntriesTable::FillerRow /> | ||
| | ||
| {{#each this.sortedBottomHalfEntries as |entry index|}} | ||
| <LeaderboardPage::EntriesTable::Row @entry={{entry}} @index={{(add 33501 index)}} /> |
There was a problem hiding this comment.
Bug: Leaderboard Rank Calculation Error
The rank calculation for bottom half leaderboard entries uses a hardcoded offset of 33501. This causes these entries to display incorrect ranks, starting from 33501 instead of continuing sequentially from the top half.
| <span class="inline-block align-middle text-red-500 triangle-down mr-1.5" aria-hidden="true"> | ||
| <EmberTooltip @text="Decreased from 199 to 99 in the past month" /> | ||
| </span> | ||
| {{/if}} |
There was a problem hiding this comment.
Bug: Score Trend Indicators Use Fixed Test Values
The score trend indicators and their tooltips are hardcoded to specific scores (142, 99) and fixed messages. This looks like test/demo code that was accidentally committed, so real score changes won't be reflected.
Test Results 1 files ±0 1 suites ±0 10m 12s ⏱️ + 1m 28s For more details on these errors, see this check. Results for commit 6144d88. ± Comparison against base commit 962994f. This pull request removes 6 and adds 1 tests. Note that renamed tests count towards both. |
❌ 2 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Bundle ReportChanges will increase total bundle size by 12.84kB (0.03%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: client-array-pushAssets Changed:
Files in
Files in
|
1 participant
No description provided.