Drop type-hints from assoc-conversion to work around AOT issue #69
Conversation
Since this function is usually not called at runtime, the reflection performance penalty should be tolerable. Fixes clj-commons#68
| Does it also fix #34? |
KingMob left a comment
KingMob left a comment There was a problem hiding this comment.
Can you make Eastwood stop complaining about the changes? https://github.com/jonase/eastwood#ignored-faults
Pretty sure it would (this patch was derived from the workaround in that ticket's description). However, according to #34 (comment) it wasn't reproducible anymore in that particular context so I didn't try anymore.
Done! |
KingMob left a comment
KingMob left a comment There was a problem hiding this comment.
Really wish Eastwood was configurable for names, not just files/lines/cols, but...
| Indeed, that's unfortunate 🤷 Note that I don't have merge rights myself here so you'll have to do the honors 🙂 |
| Dammit, let me see about adding you as a contributor |
| @DerGuteMoritz Try merging now |
| Thanks! 🙏 |
2 participants
Since this function is usually not called at runtime, the reflection performance penalty should be tolerable.
Fixes #68