Replace deprecated single-segment ns w Potemkin's import-vars #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator Author
| Fixes #65 |
Collaborator Author
| @p-himik can you try this out? |
arnaudgeiser approved these changes Dec 22, 2022
Collaborator
arnaudgeiser left a comment
arnaudgeiser left a comment There was a problem hiding this comment.
It's looking good.
It means we'll have to release a new version of Aleph with this change.
It was also causing us some issues, but as we were aware of the work that has been done on byte-streams, it was easy to do the migration on our side.
Collaborator Author
| Fair point. I held off because I was debating whether to kill the top-level test namespaces entirely. Insofar as they test behavior, there's now no way the top-level tests can fail but the clj-commons tests will succeed. But they *do* still test that the fns are available and callable. Even if I kill the other tests, I suppose I should keep that one around …On Thu, Dec 22, 2022 at 2:38 PM Arnaud Geiser ***@***.***> wrote: ***@***.**** approved this pull request. It's looking good. It means we'll have to release a new version of Aleph with this change. It was also causing us some issues, but as we were aware of the work that has been done on byte-streams, it was easy to do the migration on our side. ------------------------------ In src/byte_streams.clj <#66 (comment)> : > + ;; compare the namespaces, make sure we got everything + (require '[clojure.set :as set]) + + (set/difference Maybe this can be turned into a Clojure test and the whole comment block can be removed. — Reply to this email directly, view it on GitHub <#66 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHHB5NT7NBFCUQLUM7C3BTWOPZNLANCNFSM6AAAAAATGK7ERY> . You are receiving this because you authored the thread.Message ID: ***@***.***> |
Switch to ns-interns to avoid class comparison
arnaudgeiser approved these changes Dec 22, 2022
KingMob deleted the feature/replace-deprecated-top-level-w-import-vars branch Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Obviously, this introduces a dependency on Potemkin, but Aleph already needs it, and Potemkin has barely changed in years.