Skip to content

fix potential endless loop #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
changkun merged 2 commits into from
Apr 18, 2018
Merged

fix potential endless loop #22

changkun merged 2 commits into from
Apr 18, 2018

Conversation

@krsfrodaslz
Copy link
Contributor

@krsfrodaslz krsfrodaslz commented Apr 18, 2018

在 producer 将 done 赋值为 true 之前，如果 consumer 已经处理完最后一个数据并再次进入了等待，那么即使被唤醒，也无法跳出检查条件变量 notified 的循环。
@krsfrodaslz
Copy link
Contributor Author

krsfrodaslz commented Apr 18, 2018

另外， done 也是多个线程共享的数据，不用互斥锁保护起来是不对的。
@changkun changkun merged commit ec3e0e6 into changkun:master Apr 18, 2018
@changkun
Copy link
Owner

changkun commented Apr 18, 2018

Thanks!
@changkun changkun added the typo label May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

typo

2 participants

@krsfrodaslz @changkun