Skip to content

change std::function example to more expressible (my opinion) #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ccwanggl wants to merge 3 commits into from
Closed

change std::function example to more expressible (my opinion) #161

ccwanggl wants to merge 3 commits into from

Conversation

@ccwanggl
Copy link
Contributor

@ccwanggl ccwanggl commented Dec 26, 2020

resolve #issue_id

Description

Please describe the motivation of this pull request, and what problem was solved in this PR.

Change List

  • Fix typo error of XXX
  • Add description regarding XXX feature
  • Resolve error content of XXX

Reference

Please add reference if necessary

说明

此处详细说明 PR 的动机是什么、解决了什么样的问题。

变化箱单

  • 修复了 XXX 的 typo 错误
  • 增加了 XXX 相关的说明
  • 解决了关于 XXX 的描述性错误

参考文献

如果有请注明
changkun
changkun requested changes Dec 27, 2020
View reviewed changes
Copy link
Owner

@changkun changkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not fully convienced by this change, the code example does not include functional header, which shows no conflicts with the naming.

If you'd like to get this in, it is necessary to follow the contribution guidelines, which also make sure the change covers the code and book/en-us folders.

See CONTRIBUTING for more details.
@ccwanggl ccwanggl closed this Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@ccwanggl @changkun