Assistant API v2 #59
Merged
Assistant API v2 #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The code is just copy pasted from (now) legacy v1. Create assistant method is already being rewritten to v2 (i.e. it is not 100% v1).
Instead of files, a new concept of assistant tool's resources is used. TODO: model various response formats
EnumValue is shared among v1 and v2, although it is located in v1 at the moment. TODO: Rewrite implementation for v2
They have a slightly different model in response from request.
Thread messages are associated with attachments instead of files now. The tools in attachments support only code interpreter and file search. Thus, there cannot be a FunctionSpec.
Make JSON formats lazy implicit val-s to prevent initialization errors and allow for easier testing (some formats can be ??? and tests will still run if those are not needed).
Fix serialization in requests on several places by calling Json.toJson(_). Fix several Seq-like fields in responses to be nullable (according to spec), e.g. attachments -- in order to support decoding of sequences with a default value (Nil), utilize Jsonx library. Issue: createThreadMessage does not accept `attachments` field, even though it is described in API.
v2 API is kept in standard packages.
# Conflicts: # openai-client/src/main/scala/io/cequence/openaiscala/JsonFormats.scala # openai-client/src/main/scala/io/cequence/openaiscala/service/impl/OpenAIServiceImpl.scala # openai-client/src/test/scala/io/cequence/openaiscala/JsonFormatsSpec.scala # openai-core/src/main/scala/io/cequence/openaiscala/service/OpenAIService.scala
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.