Drone: use generate function to build jobs #836
+17 −54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files
@@ Coverage Diff @@ ## develop #836 +/- ## =========================================== - Coverage 99.00% 98.95% -0.05% =========================================== Files 70 71 +1 Lines 6837 7088 +251 =========================================== + Hits 6769 7014 +245 - Misses 68 74 +6
Continue to review full report at Codecov.
|
|
|
sdarwin force-pushed the dronegenerate branch from 48b75c7 to 7d1fe09 Compare |
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Alan has abstracted the standard cpp.al drone jobs into a
generatefunction that can be used on all repos, so adding a new compiler only needs to be done once in a central location.generatewill probably be moved to the boost-ci repository eventually.Specific notes about json: gcc 4.8 and 4.9 were using Ubuntu 14.04 Trusty before. When switching those to Ubuntu 16.04 Xenial there are errors. Skipping 4.8 and 4.9 now. You could test locally, or change .drone.star to 'gcc >=4.8' instead of 'gcc >=5.0'. Since Ubuntu 14.04 is nearly obsolete, that operating system should not continue to be used.