multi exist as bucket level interface and more tests #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
grosser force-pushed the grosser/exist branch from 3a1150d to a528154 Compare 
grosser commented Dec 14, 2016
| expect(@results['key2']).to eq(@object2) | ||
| expect(@results).to eq('key1' => @object1, 'key2' => @object2) | ||
| end | ||
| end |
There was a problem hiding this comment.
making this test catch when unexpected keys were added
grosser force-pushed the grosser/exist branch from a528154 to 414970a Compare | updated to fix rubocop, should be all green now |
| How about a merge ? :) |
Merged
| Thanks, included in #309 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
@lukebakken
FYI pretty_print prints the same as inspect, so not sure why it even needs to be defined ...