Allow arbitrary (x-anything) keys in bashly.yml

[DannyBen]

cc #426

• The ConfigValidator now ignores hash keys that start with x-
• The JSON schema now allows x- keys in all the primary objects.

@EmilySeville7cfg - can you verify this is the best way to allow x-anything? I only added it in several places, assuming there is no way to allow it everywhere.

[EmilyGraceSeville7cf]

Suggested change

	"patternProperties": { "^x-": {} }
	"patternProperties": { "^x-.": { "description": "Custom property" } }

It's better to use . not to allow properties consisting of just prefix x-. Also, we can provide hint saying that this is a custom property.

Can you provide any useful example values for these custom properties? I think we can make them even more user-friendly from Intellisence perpective. ;)

[DannyBen]

Oh - I see now the change.

[DannyBen]

Sure. I have updated the regex, feel free to push to this branch with your updates.

Example would be providing another "help" for a command, flag or arg, that will be used for man page generation:

commands: - name: status help: Show status x-manpage-help: |-  This command shows the status of all `images`, `containers` and `volumes`.  Use with `--verbose` to see deleted containers.

[EmilyGraceSeville7cf]

Everything is ready. :)

[DannyBen]

Can you approve?
I will probably change the example. If you feel it must be there, then maybe the word "anything" or "..." - anything else is confusing.

[DannyBen]

Excellent - thanks for the help.

I will change the example and probably change it to be x_ and not x- - it is easier then for users to request the property by calling command.x_anything.

[EmilyGraceSeville7cf]

Yep, I agree, underscore maybe a better alternative, to keep all property names consistent - without dashes.