chore: remove noise from test output #2386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rix0rrr approved these changes Oct 29, 2025
aws-cdk-automation pushed a commit that referenced this pull request Oct 29, 2025
- Adds `isolatedModules: true` to silence a ts-jest warning about incompatible tsc settings - Updates `class-covariant-overrides.test.ts` to use helpers so that A/ we can assert on expected errors and B/ errors are not printed to console during test run --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0 (cherry picked from commit 7da0f1f)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
github-merge-queue bot pushed a commit that referenced this pull request Oct 29, 2025
# Backport This will backport the following commits from `main` to `maintenance/v5.8`: - [chore: remove noise from test output (#2386)](#2386) <!--- Backport version: 9.5.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) Co-authored-by: Momo Kornher <kornherm@amazon.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
isolatedModules: trueto silence a ts-jest warning about incompatible tsc settingsclass-covariant-overrides.test.tsto use helpers so that A/ we can assert on expected errors and B/ errors are not printed to console during test runBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.