generated from amazon-archives/__template_Apache-2.0
- Notifications
You must be signed in to change notification settings - Fork 18
feat: intersection types #2325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: intersection types #2325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This adds support for intersection types to the jsii compiler. There are a number of restrictions to the use of intersection types: - They can only appear in argument position, or in structs that are exclusively used as the input to functions. - Not as return values of functions - Not in structs that are returned by functions - Not as arguments to constructors - Not as property types - They must intersect only (behavioral) interface types. - Not structs - Not primitives - Not class types - All shared members of interfaces that are intersected must have the same types and arguments as each other.
mrgrain reviewed Sep 11, 2025
mrgrain reviewed Sep 11, 2025
mrgrain reviewed Sep 11, 2025
mrgrain reviewed Sep 11, 2025
mrgrain requested changes Sep 11, 2025
Contributor
mrgrain left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some feedback
mrgrain approved these changes Sep 25, 2025
Signed-off-by: github-actions <github-actions@github.com>
mergify bot pushed a commit to aws/jsii that referenced this pull request Sep 29, 2025
Add support for intersection types to the rest of the jsii toolkit. This is currently using a prerelease version of the jsii compiler drafted here: aws/jsii-compiler#2325 --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
aws-cdk-automation pushed a commit that referenced this pull request Oct 29, 2025
This adds support for intersection types to the jsii compiler. There are a number of restrictions to the use of intersection types: - They can only appear in argument position, or in structs that are exclusively used as the input to functions. - Not as return values of functions - Not in structs that are returned by functions - Not as arguments to constructors - Not as property types - They must intersect only (behavioral) interface types. - Not structs - Not primitives - Not class types - All shared members of interfaces that are intersected must have the same types and arguments as each other. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0 --------- Signed-off-by: github-actions <github-actions@github.com> Co-authored-by: github-actions <github-actions@github.com> (cherry picked from commit 4ea0b82) # Conflicts: # package.json # yarn.lock
Collaborator
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
github-merge-queue bot pushed a commit that referenced this pull request Oct 29, 2025
# Backport This will backport the following commits from `main` to `maintenance/v5.8`: - [feat: intersection types (#2325)](#2325) <!--- Backport version: 9.5.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) --------- Co-authored-by: Rico Hermans <rix0rrr@gmail.com> Co-authored-by: Momo Kornher <kornherm@amazon.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This adds support for intersection types to the jsii compiler.
There are a number of restrictions to the use of intersection types:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.