Recommendations #84
Merged
Recommendations #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fixes: - Added Insights functionality (premium) - Fixed null return for Name - Fixed lay-out issue that caused Company Size (which has 2 values in LinkedIn now) to disrupt the metadata dictionary - Fixed null return for Num_Employees - Needs to be updated together with new branch for CompanyScraper
Notes: - greyed out print function at top - added get_insights module to work with the pull request I submitted for Company.py
Update Company.py to parse insights data
Gather insights data and pass to Company.py
fixing the missing personal info issue
Fix formatting of windows LI_AT instructions.
austinoboyle requested changes Oct 20, 2020
Owner
austinoboyle left a comment
austinoboyle left a comment There was a problem hiding this comment.
Thanks for the PR! I did a review of the code with some suggestions and requested changed.
This is a cleanup change that does the following: 1. Creates a new 'click_expandable_buttons' method in the base Scraper class that clicks on all expandable buttons. 2. Adds a new 'expand_recommendations_tab' method in ProfileScraper that we call after scrolling to the bottom of the page. 3. Changes Scraper.scroll_to_bottom from starting at the top of the page to starting at the current scroll position. 4. Moves 'relationship' under the 'connection' field in the recommendation.
Owner
| @zzzzzzzzzzzzz I tidied things up and added a few small fixes, and things seem to be working as expected now. Let me know if you're good with all of my changes, and I'll merge this. Thanks for all of your work :) |
Contributor Author
Yeah, everything is nice. Let's merge:) |
austinoboyle approved these changes Oct 24, 2020
Owner
| Fixes #82 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.