Feature/add array replace nth function #325
Conversation
3.7/aql/functions-array.md Outdated
| - **position** (number): the position of the element to replace. Positions start | ||
| at 0. Negative positions are not supported. | ||
| at 0. Negative positions are supported, with -1 being the last array element. | ||
| If a negative *position* is out of bounds, the array is returned unmodified. |
There was a problem hiding this comment.
@dothebart Shouldn't the behavior be symmetric with out-of-bounds positive positions? Raise an error if the index points before the first element (or two before it?) unless a padding value is provided leading to [newValue, pad1, pad2, padN, ...oldValues]?
There was a problem hiding this comment.
make this an if < 0 throw?
replaceOffset = (static_cast<int64_t>(length) + posParam < 0) ? 0: static_cast<uint64_t>(length + posParam); padding below [0] doesn't make sense imho?
There was a problem hiding this comment.
It would be pretty uncommon. Since we raise a runtime error when no padding value is provided and the position > length, I think it would make sense to throw also if a negative position points below the first element (or two before 0 to behave analogous to positive positions, where one element after the last is allowed?).
Instead of throwing an error, we could also log a warning in both cases and return the array unaltered. We should definitely not ignore it silently, and I don't have a good feeling about capping the value to a minimum of 0.
2 participants
documentation change for arangodb/arangodb#11042