This repository was archived by the owner on Dec 13, 2023. It is now read-only.
Refactor batch API docs #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
|
… into feature/batch-api-refactor
… into feature/batch-api-refactor
Simran-B suggested changes Sep 16, 2019
| | ||
|  | ||
| | ||
| From the outside this process is fully transparent: >ou talk to any _Coordinator_ |
There was a problem hiding this comment.
Suggested change
| From the outside this process is fully transparent: >ou talk to any _Coordinator_ | |
| From the outside this process is fully transparent: you talk to any _Coordinator_ |
| | ||
| From the outside this process is fully transparent: >ou talk to any _Coordinator_ | ||
| and whenever you read or write data | ||
| it will automatically figure out where the data is stored (read) or to |
There was a problem hiding this comment.
Suggested change
| it will automatically figure out where the data is stored (read) or to | |
| it will automatically figure out where the data is (to be) stored. |
| From the outside this process is fully transparent: >ou talk to any _Coordinator_ | ||
| and whenever you read or write data | ||
| it will automatically figure out where the data is stored (read) or to | ||
| be stored (write). The information about the _shards_ is shared across the |
There was a problem hiding this comment.
Suggested change
| be stored (write). The information about the _shards_ is shared across the | |
| The information about the _shards_ is shared across the _Coordinators_ using the _Agency_. |
| Note however that if you change the shard keys from their default `["_key"]`, then finding | ||
| a document in the collection by its primary key involves a request to | ||
| every single shard. However this can be mitigate: All CRUD APIs and AQL | ||
| support taking the shard key values as a lookup hint. |
There was a problem hiding this comment.
How do you hint the shard key in practice?
Simran-B reviewed Sep 17, 2019
3.6/administration-cluster.md Outdated
| support taking the shard keys as a lookup hint. | ||
| every single shard. However this can be mitigated: All CRUD APIs and AQL | ||
| support taking the shard keys as a lookup hint. Just send them as part | ||
| of the update / replace or removal operation. |
There was a problem hiding this comment.
I assume the respective attributes need to be present in the request for the CRUD APIs?
In case of AQL, does it work with all syntax variants?
UPDATE "docKey" WITH { myShardAttribute: "foo", ... }UPDATE { _key: "docKey", myShardAttribute: "foo", ...}UPDATE { _key: "docKey", myShardAttribute: "foo" } WITH { ... }???UPSERT { _key: "docKey", myShardAttribute: "foo" }... ?UPSERT { _key: "docKey" } INSERT { myShardAttribute: "foo", ... } UPDATE { myShardAttribute: "foo", ... }?
There was a problem hiding this comment.
Yes feel free to add it to the docs yourself. This always used to work reliably except for remove operations, new in 3.6 is only that it now does work everywhere
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
arangodb/arangodb#10015
http://jenkins01.arangodb.biz:8080/view/Documentation/job/arangodb-ANY-examples/345/