Skip to content
This repository was archived by the owner on Dec 13, 2023. It is now read-only.

Conversation

@jwierzbo
Copy link
Contributor

No description provided.

@jwierzbo jwierzbo requested a review from Simran-B January 17, 2023 11:54
@cla-bot cla-bot bot added the cla-signed label Jan 17, 2023
@jwierzbo jwierzbo requested a review from a team January 17, 2023 11:54
@jwierzbo jwierzbo force-pushed the GT-312_doc_for_backup_on_eks branch from 98c64f5 to c37431c Compare January 17, 2023 11:55
@jwierzbo jwierzbo force-pushed the GT-312_doc_for_backup_on_eks branch from c37431c to 86112ac Compare January 17, 2023 12:02
--name SA_NAME \
--namespace NAMESPACE \
--cluster CLUSTER_NAME \
--attach-policy-arn arn:aws:iam::ACCONT_ID:policy/S3-ACCESS_ROLE \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--attach-policy-arn arn:aws:iam::ACCONT_ID:policy/S3-ACCESS_ROLE \
--attach-policy-arn arn:aws:iam::ACCOUNT_ID:policy/S3-ACCESS_ROLE \
--name SA_NAME \
--namespace NAMESPACE \
--cluster CLUSTER_NAME \
--attach-policy-arn arn:aws:iam::ACCONT_ID:policy/S3-ACCESS_ROLE \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--attach-policy-arn arn:aws:iam::ACCONT_ID:policy/S3-ACCESS_ROLE \
--attach-policy-arn arn:aws:iam::ACCOUNT_ID:policy/S3-ACCESS_ROLE \
--name SA_NAME \
--namespace NAMESPACE \
--cluster CLUSTER_NAME \
--attach-policy-arn arn:aws:iam::ACCONT_ID:policy/S3-ACCESS_ROLE \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--attach-policy-arn arn:aws:iam::ACCONT_ID:policy/S3-ACCESS_ROLE \
--attach-policy-arn arn:aws:iam::ACCOUNT_ID:policy/S3-ACCESS_ROLE \
--name SA_NAME \
--namespace NAMESPACE \
--cluster CLUSTER_NAME \
--attach-policy-arn arn:aws:iam::ACCONT_ID:policy/S3-ACCESS_ROLE \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--attach-policy-arn arn:aws:iam::ACCONT_ID:policy/S3-ACCESS_ROLE \
--attach-policy-arn arn:aws:iam::ACCOUNT_ID:policy/S3-ACCESS_ROLE \
Copy link
Contributor

@informalict informalict left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nerpaula nerpaula merged commit 6448a71 into main Jan 18, 2023
@nerpaula nerpaula deleted the GT-312_doc_for_backup_on_eks branch January 18, 2023 14:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

6 participants