Fix calculation of mask for constant values #7507
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This fixes an error when a constant is being loaded into a flag. The constants associated with a flag value have their size set to zero. That causes the mask for the constant value to be all zeros. Due to that, getting the value of a zero sized constant will always return 0 even if it should be 1. This commit special cases the size of zero to create a mask of 1 which will correctly mask off the lowest byte and return that as the constant.
james-a-johnson requested a deployment to testing 
GitHub Actions Waiting 
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the mask calculation for constant values with zero size, which prevented correct retrieval of flag constant values. The fix special-cases size zero to return a mask of 1, ensuring the lowest byte is correctly extracted.
Key Changes
- Modified mask calculation logic to handle zero-sized constants by returning a mask value of 1
- Refactored the mask calculation from mutable variable assignment to an immutable conditional expression
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| mask = !mask; | ||
| } | ||
| let mask: u64 = if self.op.size == 0 { | ||
| 1 |
There was a problem hiding this comment.
A mask of 1 will only preserve the least significant bit, not the lowest byte. To correctly mask the lowest byte as described in the PR description, the mask should be 0xFF (255) instead of 1.
Suggested change
| 1 | |
| 0xFF |
Contributor Author
There was a problem hiding this comment.
Nice catch. That is a bug in the wording of my MR message though and not the actual code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This fixes an error when a constant is being loaded into a flag. The constants associated with a flag value have their size set to zero. That causes the mask for the constant value to be all zeros. Due to that, getting the value of a zero sized constant will always return 0 even if it should be 1.
This commit special cases the size of zero to create a mask of 1 which will correctly mask off the lowest bit and return that as the constant.