Merged forked release 2.8.0 (a2R1T000002QTyrUAG) #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* Added 'disabled' attribute and bumped version * Prevent selection changes when disabled * Updated readme * Fixed typo in comments * Revert test change in sample app
* Bumped devDependencies * Replaced isExpanded() with hasResults() * Added support for new record creation
Add inline variant support
Support for custom minimum search term length
Fixed regex injection
Allow the new record modal to be prepopulated with default field values. A string of comma-separated key/value pairs (i.e. "Key1=Value1,Key2=Value2") is assigned to the component property data-defaults and is passed to the new record NavigationMixin as a state property. Example: newRecordOptions = [ { value: 'Account', label: 'New Account', defaults: "Name=Test,Type=Prospect" } ] Add defaultFieldValues to newRecordOptions
Allow search results to be extended to support additional class attributes.
Make LookupSearchResult a virtual class
Added pre-navigate callback
Author
| @rajas94 I put you as reviewer as you created "additional feature". |
itsmebasti approved these changes Feb 23, 2021
itsmebasti left a comment
itsmebasti left a comment There was a problem hiding this comment.
nice, looks good.
I also compared it to main and saw that you could even improve or revert some things 👍
Interesting that they also stumbled over the regexp, maybe we should have contributed some changes..
Author
| I merged it locally and pushed through local git. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
lwc test should run: execute npm test
apex test should run