Multiselect Lookup (LWC): Performance Improvement on large Data (a2R1T000002QLM5UAO) #2
Conversation
gorazd-up2go left a comment
gorazd-up2go left a comment There was a problem hiding this comment.
lookupRendering.test.js is missing tests for new functionality for example to disable and showing label on hasMoreResultsToDisplay
| @rajas94 There is one more minor improvement I think of and somebody else should look at it as well. |
gorazd-up2go left a comment
gorazd-up2go left a comment There was a problem hiding this comment.
I think it is ok but somebody else should look at it.
itsmebasti left a comment
itsmebasti left a comment There was a problem hiding this comment.
there are to many non trivial changes, that will be hard to merge and maintain in the future, let's try to find a more "extending" solution.
src/main/default/lwc/lookup/__tests__/lookupEventFiring.test.js Outdated Show resolved Hide resolved
itsmebasti left a comment
itsmebasti left a comment There was a problem hiding this comment.
Let's reduce the custom changes to reduce merging effort
| } | ||
| | ||
| get hasMoreResultsToDisplay() { | ||
| return this._hasFocus && this._searchResultsCount > this.resultsToDisplay; |
There was a problem hiding this comment.
can you explain how search result counts are related to hasFocus? maybe add a note if this is really needed
There was a problem hiding this comment.
we only want to display the helper text when the user is searching for something, as soon as he moves away from the input we don't want to display the text
| } | ||
| | ||
| handleClearSelection() { | ||
| if (this.disabled) { |
There was a problem hiding this comment.
short question, what is the difference between the clear and the remove method?
There was a problem hiding this comment.
handleRemoveSelectedItem is used to remove multi-select items and handleClearSelection is used to remove single entry lookup selection
Please look into the usage of lookup here in order to get an idea of lookup properties. Please feel free to reach out to me if you have any ideas/questions.