Skip to content

Extract tests on Exceptions into examples-part10 #2596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2023
Merged

Extract tests on Exceptions into examples-part10 #2596

merged 1 commit into from
Sep 13, 2023

Conversation

@alisevych
Copy link
Member

@alisevych alisevych commented Sep 13, 2023 •
edited
Loading

Description

build_and_run_tests workflow started to fail frequently with examples-part2 run.
Tests in exceptions package take most of the time and memory, especially JvmCrashExamplesTest.
So they are separated into examples-part10.

How to test

Manual tests

  1. Open Actions
  2. Select this branch
  3. Run workflow
  4. Check how long the run takes and whether it fails or not.

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.
@alisevych alisevych added comp-infrastructure Infrastructure issues ctg-qa Issue is related to QA process ctg-bug-fix PR is fixing a bug labels Sep 13, 2023
@alisevych alisevych added this to the September Release milestone Sep 13, 2023
@alisevych alisevych requested a review from bissquit September 13, 2023 08:19
@alisevych alisevych self-assigned this Sep 13, 2023
bissquit
bissquit approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@bissquit bissquit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@alisevych alisevych merged commit 27a4697 into main Sep 13, 2023
@alisevych alisevych deleted the alisevych/test_run_separation branch September 13, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp-infrastructure Infrastructure issues ctg-bug-fix PR is fixing a bug ctg-qa Issue is related to QA process

3 participants

@alisevych @bissquit