Skip to content

Conversation

@IlyaMuravjov
Copy link
Collaborator

@IlyaMuravjov IlyaMuravjov commented Aug 29, 2023

Description

Makes ValidEntityValueProvider recognize annotations from javax.validation.constraints.

How to test

Manual tests

  • Open spring-boot-testing project

  • Add spring-boot-starter-validation dependency

  • Add @NotEmpty and @Email annotations to Order.buyer field

  • Generate integration tests for OrderService.getOrderById()

  • There should be test that saves valid Order to the database

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.
@IlyaMuravjov IlyaMuravjov added ctg-enhancement New feature, improvement or change request comp-spring Issue is related to Spring projects support labels Aug 29, 2023
@EgorkaKulikov EgorkaKulikov enabled auto-merge (squash) August 29, 2023 17:20
@EgorkaKulikov EgorkaKulikov merged commit 1480d4b into main Aug 29, 2023
@EgorkaKulikov EgorkaKulikov deleted the ilya_m/javax-validation branch August 29, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp-spring Issue is related to Spring projects support ctg-enhancement New feature, improvement or change request

3 participants