Skip to content

Conversation

@vil02
Copy link
Member

@vil02 vil02 commented May 31, 2025

Pull Request Template

Description

This PR removes the manual_midpoint from the list of suppressed lints. Continuation of #883.

Checklist:

  • I ran bellow commands using the latest version of rust nightly.
  • I ran cargo clippy --all -- -D warnings just before my last commit and fixed any issue that was found.
  • I ran cargo fmt just before my last commit.
  • I ran cargo test just before my last commit and all tests passed.
  • I added my algorithm to the corresponding mod.rs file within its own folder, and in any parent folder(s).
  • I added my algorithm to DIRECTORY.md with the correct link.
  • I checked COUNTRIBUTING.md and my code follows its guidelines.

Please make sure that if there is a test that takes too long to run ( > 300ms), you #[ignore] that or
try to optimize your code or make the test easier to run. We have this rule because we have hundreds of
tests to run; If each one of them took 300ms, we would have to wait for a long time.

@vil02 vil02 requested a review from siriak May 31, 2025 19:53
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.51%. Comparing base (bc3ef17) to head (3a1a936).

Additional details and impacted files
@@ Coverage Diff @@ ## master #884 +/- ## ======================================= Coverage 95.51% 95.51% ======================================= Files 317 317 Lines 22954 22954 ======================================= Hits 21924 21924 Misses 1030 1030 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@vil02 vil02 marked this pull request as ready for review May 31, 2025 19:57
@vil02 vil02 requested a review from imp2002 as a code owner May 31, 2025 19:57
@siriak siriak merged commit 5839fb4 into TheAlgorithms:master Jun 1, 2025
4 checks passed
@vil02 vil02 deleted the include_manual_midpoint branch June 1, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants