Skip to content

Conversation

@vil02
Copy link
Member

@vil02 vil02 commented Jan 27, 2025

Pull Request Template

Description

This PR removes rand_chacha from the dependencies as it is not needed.

Related to:

Checklist:

  • I ran bellow commands using the latest version of rust nightly.
  • I ran cargo clippy --all -- -D warnings just before my last commit and fixed any issue that was found.
  • I ran cargo fmt just before my last commit.
  • I ran cargo test just before my last commit and all tests passed.
  • I added my algorithm to the corresponding mod.rs file within its own folder, and in any parent folder(s).
  • I added my algorithm to DIRECTORY.md with the correct link.
  • I checked COUNTRIBUTING.md and my code follows its guidelines.

Please make sure that if there is a test that takes too long to run ( > 300ms), you #[ignore] that or
try to optimize your code or make the test easier to run. We have this rule because we have hundreds of
tests to run; If each one of them took 300ms, we would have to wait for a long time.

@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.49%. Comparing base (c162aa9) to head (4e542bb).

Additional details and impacted files
@@ Coverage Diff @@ ## master #866 +/- ## ======================================= Coverage 95.49% 95.49% ======================================= Files 316 316 Lines 22922 22922 ======================================= Hits 21889 21889 Misses 1033 1033 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vil02 vil02 requested a review from siriak January 27, 2025 21:24
@vil02
Copy link
Member Author

vil02 commented Jan 27, 2025

@siriak: the CI needs #865. I will mark it as ready for review, but please rebase it before merging.

@vil02 vil02 marked this pull request as ready for review January 27, 2025 21:27
@vil02 vil02 requested a review from imp2002 as a code owner January 27, 2025 21:27
@siriak siriak merged commit b78cb6a into TheAlgorithms:master Jan 28, 2025
4 checks passed
@vil02 vil02 deleted the remove_rand_chacha_dep branch January 28, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants