feat: add basic image filtering filter.py #7155
Conversation
algorithms-keeper bot added require tests ![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
fix: validate filenames
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| | ||
| | ||
| class Filter: | ||
| def __int__(self, image: str) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file computer_vision/filter.py, please provide doctest for the function __int__
| | ||
| self.image = image | ||
| | ||
| def image_read(self) -> np.array: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file computer_vision/filter.py, please provide doctest for the function image_read
| """ | ||
| return cv2.imread(self.image, 0) | ||
| | ||
| def get_identity_kernel(self) -> np.array: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file computer_vision/filter.py, please provide doctest for the function get_identity_kernel
| """ | ||
| return np.array([[0, 0, 0], [0, 1, 0], [0, 0, 0]]) | ||
| | ||
| def get_blur_kernel(self) -> np.array: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file computer_vision/filter.py, please provide doctest for the function get_blur_kernel
| ] | ||
| ) | ||
| | ||
| def get_sharp_kernel(self) -> np.array: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file computer_vision/filter.py, please provide doctest for the function get_sharp_kernel
| kernel = self.get_identity_kernel() | ||
| return self.set_up_filter(kernel) | ||
| | ||
| def blur_filter(self) -> np.array: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file computer_vision/filter.py, please provide doctest for the function blur_filter
| kernel = self.get_blur_kernel() | ||
| return self.set_up_filter(kernel) | ||
| | ||
| def gaussian_blur(self) -> np.array: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file computer_vision/filter.py, please provide doctest for the function gaussian_blur
| ) | ||
| return gaussian_blur_filter_image | ||
| | ||
| def median_blur(self) -> np.array: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file computer_vision/filter.py, please provide doctest for the function median_blur
| median_blur_filtered_image = cv2.medianBlur(src=image, ksize=9) | ||
| return median_blur_filtered_image | ||
| | ||
| def sharp_filter(self) -> np.array: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file computer_vision/filter.py, please provide doctest for the function sharp_filter
| kernel = self.get_sharp_kernel() | ||
| return self.set_up_filter(kernel) | ||
| | ||
| def emboss_filter(self) -> np.array: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file computer_vision/filter.py, please provide doctest for the function emboss_filter
2 participants
Describe your change:
Checklist: